-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play gifs #1805
Comments
Hello Private Gump, unluckily this is due to the fact that the server does not offer gif previews. And we use previews to prevent size troubles. So I would either move this to the server, or someone tells me how we can savely detect the size and use the original file then instead. yours |
Having gif preiew would also be nice for Android, as this is also requested there. |
In the viewer if a file is a gif, we just don't use the preview but fetch the dav url directly. :) |
Let's involve the preview expert @rullzer |
Gif files can be quite large, having this fetched (at least on mobile) is something I do not want (e.g. Talk on mobile or files app). |
So for me it is still not clear what a gif preview would do. Because we can't just take every 100th frame. etc. Fetching the whole file is the only way I really see for animated gifs... |
@tobiasKaminsky @rullzer imgur started converting gifs to video if they were over 1.5MB (or something). This allowed them to serve lots of data without disturbing the user experience :) We could have a preview provider for that? |
Could also have the preview with a play icon on top and if you click it we play the full thing? |
Could be nice, if a file is over xxxMB, I feel like we should not completely rule out autoplay 😁 |
While encoding them to mp4 is probably gonna save a LOT of space (gifs are insanely inefficient) we don't preview videos either... a play button is probably best, and maybe (later?) auto-play when scrolling into view and pausing the scroll (like 'others' do, like twitter). |
Couldn't you just do that, and then have a cron job that "cleans up" old gifs in talk by replacing them with just a still after, like, a month or something? EDIT: By the way I guess I'm just commenting to bitch about features that are missing, but you guys are unbelievable rockstars. The amount of value you guys have made for people with Nextcloud is next-!@#$ing-level - mad props all around, I want to buy y'all AT LEAST some beers. |
As far as I can see if you enable the preview provider For the short term (quickfix), I propose to do the following in the Talk app:
Edit: added cropping |
Also, improve the inline flow of gifs a bit, no cropping, looks more like an inline message than an attachement? :) |
For detecting the file size: Or do a HEAD call on the read file and read the Content-Length property. |
This seems to be a general issue, also with other pictures. |
You should already have this in the message I think. |
I've implemented the cropping/ratio fix separately, see #4469 |
indeed, reddit converts to mp4, look at that url... https://external-preview.redd.it/yDHSdJSPeLvke9OlYUCRVjA0a8U6gBjWd3DfpG_SWZQ.gif?format=mp4&s=57a4a0877d90467317d2f3bcad158b98fec98410 |
PR here that brings rendering of GIFs: #4471 |
For the server bit, I found this ticket about transcoding videos to another format in order to be able to play them in the browser: nextcloud/server#21633 The animated GIF thing would simply be an additional format that could be converted to a browser-compatible video format for playback. |
When I use my reaction gifs, they stay still, defeating the purpose of my dank memes collection! 😁
The text was updated successfully, but these errors were encountered: