Fix sidebar's title alignment

[marcoambrosini]

Fix #2565

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

[skjnldsv]

Nope, fix in globally in the vue components if it's needed please

Also, only the favorite should be aligned: nextcloud-libraries/nextcloud-vue#340 (comment)

Right actions/close are expected to be top right

[nickvergessen]

Also conflict and there should not be package-lock.json changes in here

[marcoambrosini]

Also, only the favorite should be aligned: nextcloud-libraries/nextcloud-vue#340 (comment)
Right actions/close are expected to be top right

I don't understand this part @skjnldsv

[skjnldsv]

Also, only the favorite should be aligned: nextcloud/nextcloud-vue#340 (comment)
Right actions/close are expected to be top right

on the screenshot, the only issue is the favorite icon alignment with the title.
To be fair, it looks weird, why is it bold? We never use bold in nextcloud it should be like the screenshots on nextcloud-libraries/nextcloud-vue#340 (comment)
Or like the current files sidebar.

I just tried it again on server (files, so 0.12.7), and it's all fine

[nickvergessen]

Well we modified the heading to h2 in nextcloud-libraries/nextcloud-vue#710 as per Jan's request. And it seems since then the padding is off

I guess https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/AppSidebar/AppSidebar.vue#L550 need adjusting to substract only like 8 or 9

[marcoambrosini]

on the screenshot, the only issue is the favorite icon alignment with the title.

The issue is the text sliding down outside its container and being cut!

[nickvergessen]

Conflicting files
src/components/RightSidebar/RightSidebar.vue

Please rebase on latest master

[skjnldsv]

Nope, fix in globally in the vue components if it's needed please

Please forward this fix to the vue components.

[marcoambrosini]

But isn't this bold title version a talk only feature? Without changing that there's no need for this fix as you pointed out :)

[marcoambrosini]

But in general yes, there are a bunch of v-deep around and after 18 I'm going to forward the changes to the vue library

[nickvergessen]

See #2589 (comment)

[skjnldsv]

But isn't this bold title version a talk only feature?

Has this been validated by Jan? Why do we have bold title here?

[nickvergessen]

Its h2, its always bold

[skjnldsv]

Then it's an issue I think
cc @jancborchardt :)

[nickvergessen]

Well its the headline of the sidebar, exactly what it should be?

[jancborchardt]

We did talk about making it bold as it helps people see what’s the focus here. It’s intended to be bold. :)

[skjnldsv]

Thanks a lot :)