Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust header elements #710

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Adjust header elements #710

merged 2 commits into from
Nov 22, 2019

Conversation

nickvergessen
Copy link
Contributor

cc @jancborchardt as discussed

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Nov 7, 2019
@nickvergessen nickvergessen added this to the 1.2.1 milestone Nov 7, 2019
jancborchardt
jancborchardt approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense semantically and size-wize for the title as well. :) 👍

skjnldsv
skjnldsv requested changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/nextcloud/nextcloud-vue/blob/2b91823756b90ab251405fc8d8094bcf8be3f633/src/components/AppSidebar/AppSidebar.vue#L528
https://github.com/nextcloud/nextcloud-vue/blob/2b91823756b90ab251405fc8d8094bcf8be3f633/src/components/AppSidebar/AppSidebar.vue#L538

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 7, 2019
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 7, 2019

/backport to stable0-12

@nickvergessen nickvergessen force-pushed the bugfix/noid/adjust-header-elements branch from 2b91823 to c168b27 Compare November 7, 2019 12:51
@nickvergessen
Adjust header elements
c51d4bc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/adjust-header-elements branch from c168b27 to c51d4bc Compare November 7, 2019 22:24
jancborchardt
jancborchardt approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 9, 2019
skjnldsv
skjnldsv requested changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

@jancborchardt
Copy link
Contributor

Btw @georgehrke is this something which then needs to be changed for the component which Calendar uses, or is it just the same?

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 20, 2019
@nickvergessen
Adjust CSS selector for the h2 aswell
cdd4f19 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen removed the 2. developing Work in progress label Nov 22, 2019
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Nov 22, 2019
@skjnldsv skjnldsv merged commit 27027be into master Nov 22, 2019
@skjnldsv skjnldsv deleted the bugfix/noid/adjust-header-elements branch November 22, 2019 11:58
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 22, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable0-12 in #734

@nickvergessen nickvergessen mentioned this pull request Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @skjnldsv @jancborchardt