[stable12] Show EOL warning in the update section #8987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
enhancement
3. to review
MorrisJobke
reviewed
Apr 12, 2018
| @@ -107,14 +107,14 @@ public function displayPanel() { | |||
| $notifyGroups = json_decode($this->config->getAppValue('updatenotification', 'notify_groups', '["admin"]'), true); | |||
|
|
|||
| $params = [ | |||
| 'isNewVersionAvailable' => !empty($updateState['updateAvailable']), | |||
| 'isNewVersionAvailable' => true, //!empty($updateState['updateAvailable']), | |||
MorrisJobke
force-pushed
the
backport/8821/show-eol-warning-12
branch
from
6737553
to
30626ed
Compare
Codecov Report
@@ Coverage Diff @@
## stable12 #8987 +/- ##
==============================================
- Coverage 53.91% 53.91% -0.01%
- Complexity 22780 22782 +2
==============================================
Files 1387 1387
Lines 87286 87295 +9
Branches 1331 1331
==============================================
+ Hits 47063 47065 +2
- Misses 40223 40230 +7
|
MorrisJobke
approved these changes
Apr 12, 2018
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/8821/show-eol-warning-12
branch
from
30626ed
to
5f1f633
Compare
|
Rebased and fixed the last failing test |
rullzer
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8986