Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Show EOL warning in the update section #8986

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

nickvergessen
Copy link
Member

Backport #8821

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

Rebased to retrigger CI

@MorrisJobke MorrisJobke force-pushed the backport/8821/show-eol-warning branch from 9321eb1 to 5c0ec6e Compare April 12, 2018 09:38
@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #8986 into stable13 will decrease coverage by 16.68%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             stable13    #8986       +/-   ##
===============================================
- Coverage       51.33%   34.64%   -16.69%     
- Complexity      25040    25042        +2     
===============================================
  Files            1609     1609               
  Lines           95317    95325        +8     
  Branches         1376     1376               
===============================================
- Hits            48929    33030    -15899     
- Misses          46388    62295    +15907
Impacted Files Coverage Δ Complexity Δ
...atenotification/lib/Controller/AdminController.php 0% <0%> (-66.67%) 12 <0> (+1)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Updater/VersionCheck.php 0% <0%> (-92.11%) 8 <0> (+1)
apps/updatenotification/lib/UpdateChecker.php 0% <0%> (-75%) 9 <0> (ø)
...te/Authentication/LoginCredentials/Credentials.php 0% <0%> (-100%) 4% <0%> (ø)
...s/dav/lib/CalDAV/BirthdayCalendar/EnablePlugin.php 0% <0%> (-100%) 7% <0%> (ø)
...ty/Exceptions/CrossSiteRequestForgeryException.php 0% <0%> (-100%) 1% <0%> (ø)
...curity/Exceptions/StrictCookieMissingException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/App/AppStore/Version/Version.php 0% <0%> (-100%) 3% <0%> (ø)
... and 526 more

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Rebased and fixed the last failing test

@MorrisJobke MorrisJobke mentioned this pull request Apr 18, 2018
11 tasks
@rullzer rullzer merged commit cbe03cb into stable13 Apr 18, 2018
@rullzer rullzer deleted the backport/8821/show-eol-warning branch April 18, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants