-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] Use darker colors for app icons in app management #897
Conversation
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @jancborchardt and @PVince81 to be potential reviewers |
works 👍 @MorrisJobke btw. there are no new icons, we will stay with the white icon files and always use the inverting for now. |
Ah right ... I mixed this up with the theming: like nextcloud/notifications#9 Thanks :) |
looks good 👍 |
@juliushaertl always remember to delete the branch when it has been merged. ;) (Just did it) |
@jancborchardt Ok, will do next time. Always thought that would be happening automatically. ;) |
@juliushaertl yeah, that would be nice right? :D Mailed Github about that some time ago and they said it’s on their roadmap but won’t happen in the near future unfortunately. |
Backport of #834
I tested it with the news app (which has an old icon) and it works really nice :)
@Mar1u5 @juliushaertl @raghunayyar @Bugsbane @schiessle @rullzer @nextcloud/designers Please review :)