Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Use darker colors for app icons in app management #897

Merged
merged 4 commits into from
Aug 17, 2016

Conversation

MorrisJobke
Copy link
Member

Backport of #834

I tested it with the news app (which has an old icon) and it works really nice :)

bildschirmfoto 2016-08-17 um 10 03 44

bildschirmfoto 2016-08-17 um 10 03 58

@Mar1u5 @juliushaertl @raghunayyar @Bugsbane @schiessle @rullzer @nextcloud/designers Please review :)

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Aug 17, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 10.0 milestone Aug 17, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @jancborchardt and @PVince81 to be potential reviewers

@juliusknorr
Copy link
Member

works 👍

@MorrisJobke btw. there are no new icons, we will stay with the white icon files and always use the inverting for now.

@MorrisJobke
Copy link
Member Author

@MorrisJobke btw. there are no new icons, we will stay with the white icon files and always use the inverting for now.

Ah right ... I mixed this up with the theming: like nextcloud/notifications#9

Thanks :)

@schiessle
Copy link
Member

looks good 👍

@juliusknorr juliusknorr merged commit 29e45dd into stable10 Aug 17, 2016
@jancborchardt
Copy link
Member

@juliushaertl always remember to delete the branch when it has been merged. ;) (Just did it)

@jancborchardt jancborchardt deleted the stable10-backport-834 branch August 17, 2016 09:15
@juliusknorr
Copy link
Member

@jancborchardt Ok, will do next time. Always thought that would be happening automatically. ;)

@jancborchardt
Copy link
Member

@juliushaertl yeah, that would be nice right? :D Mailed Github about that some time ago and they said it’s on their roadmap but won’t happen in the near future unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants