Use dark icons for app management

[jancborchardt]

As a follow-up of #627 (white app menu with dark icons) it would be good for consistency if the app management would also use dark icons. Then we can also get rid of the strange grey box we needed to make the white icons visible.

@juliushaertl are you also up for this? ;) cc @nextcloud/designers

[Bugsbane]

Let me know if you need the actual SVG's modified to make them darker (ie if it's not being done in code), and I'll take care of it. Given the simplicity of the icons though, I'd say there's a good chance we could just do a find and replace on them all for:

Find:
fill="#FFF"

Replace:
fill="#000"

[raghunayyar]

I would like to take this up if no one is doing this. :-)

[raghunayyar]

Simply replacing the fill works for me. There is a PR already on this. ;)

[juliusknorr]

I'd propose to just keep with the white icons as svg files and use the color inversion trick (like here:

server/core/templates/layout.user.php

Lines 116 to 119 in 5d0f9da

	<svg width="32" height="32" viewBox="0 0 32 32">
	<defs><filter id="invert"><feColorMatrix in="SourceGraphic" type="matrix" values="-1 0 0 0 1 0 -1 0 0 1 0 0 -1 0 1 0 0 0 1 0" /></filter></defs>
	<image x="0" y="0" width="32" height="32" preserveAspectRatio="true" filter="url(#invert)" xlink:href="<?php print_unescaped($entry['icon']); ?>" class="app-icon"/>
	</svg>

) to render them as black icons in the app management as well.

Otherwise we would have some white icons on white background for apps we don't maintain.

[Bugsbane]

I'd propose to just keep with the white icons as svg files and use the color inversion trick

Agreed. I suggested that earlier more as a hack for if we didn't find a better way, which we did.

[juliusknorr]

pr #834
stable10 #897

[Mannshoch]

I would Like to use a dark color for the bar at top. How could I change to normal?

[jancborchardt]

@Mannshoch you probably use the »Direct Menu« which conveniently enough is also developed by the awesome @juliushaertl ;)

@juliushaertl if that app is enabled, then for bright header bar colors it probably makes sense to use the dark icons just as we switch the font to black for better contrast.

[juliusknorr]

@jancborchardt That should already work like that 😄

[jancborchardt]

@juliushaertl hehe! Nice :D

@Mannshoch what’s your problem then?

[Mannshoch]

@jancborchardt Yes, your Right I use »Direct Menu« in which CSS File do I have to manipulate this? Or would you maybe add a checkbox which allow to switch the color?

[juliusknorr]

@Mannshoch the color of the icons should be switched automatically if the chosen theming color is too bright. (If you are using direct_menu version 0.9.1 or later) Maybe opening an issue over at https://github.com/juliushaertl/direct_menu/ would be better then discussing here. 😉