Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12] disable part files for object stores #8726

Merged
merged 2 commits into from
Mar 9, 2018
Merged

[12] disable part files for object stores #8726

merged 2 commits into from
Mar 9, 2018

Conversation

icewind1991
Copy link
Member

Backport of #8715

@icewind1991
disable part files for object stores
50162e6 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
emit pre-hooks earlier when not using part files
550f9ca 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 8, 2018
@icewind1991 icewind1991 added this to the Nextcloud 12.0.6 milestone Mar 8, 2018
@codecov
Copy link

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #8726 into stable12 will not change coverage.
The diff coverage is 25%.

@@             Coverage Diff             @@
##             stable12    #8726   +/-   ##
===========================================
  Coverage       53.91%   53.91%           
- Complexity      22777    22779    +2     
===========================================
  Files            1387     1387           
  Lines           87285    87285           
  Branches         1331     1331           
===========================================
  Hits            47062    47062           
  Misses          40223    40223
Impacted Files Coverage Δ Complexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.39% <0%> (-0.56%) 75 <1> (+1)
apps/dav/lib/Connector/Sabre/File.php 71.7% <50%> (+0.16%) 100 <0> (+1) ⬆️
lib/private/Server.php 84.68% <0%> (-0.13%) 121% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
Merged
2 tasks
MorrisJobke
MorrisJobke approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit aee8381 into stable12 Mar 9, 2018
@MorrisJobke MorrisJobke deleted the objectstore-no-part-files-12 branch March 9, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @MorrisJobke