-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable part files for object stores #8715
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs more work.
If I checkout this branch we directly create a new version on upload.
Signed-off-by: Robin Appelman <robin@icewind.nl>
Codecov Report
@@ Coverage Diff @@
## master #8715 +/- ##
===========================================
- Coverage 51.87% 51.8% -0.08%
- Complexity 25367 25368 +1
===========================================
Files 1607 1607
Lines 95154 95156 +2
Branches 1379 1379
===========================================
- Hits 49362 49294 -68
- Misses 45792 45862 +70
|
@rullzer fixed (this probably also was an issue when using s2s sharing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to do the trick!
Renaming the part file to the target file while preserving fileids can't be done for object stores without issues.
To test