Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] Use S3Client::upload instead of splitting single/multipart upload ourselves #8101

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

icewind1991
Copy link
Member

Backport of #8033

…selves

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991 icewind1991 added this to the Nextcloud 12.0.6 milestone Jan 29, 2018
@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #8101 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #8101      +/-   ##
==============================================
+ Coverage       53.84%   53.85%   +<.01%     
+ Complexity      22761    22753       -8     
==============================================
  Files            1385     1385              
  Lines           87150    87121      -29     
  Branches         1331     1331              
==============================================
- Hits            46926    46915      -11     
+ Misses          40224    40206      -18
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php 75% <100%> (+17.1%) 5 <0> (-8) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

MorrisJobke
MorrisJobke approved these changes Feb 8, 2018
@MorrisJobke MorrisJobke merged commit 08a13dd into stable12 Feb 8, 2018
@MorrisJobke MorrisJobke deleted the s3-uploader-12 branch February 8, 2018 13:31
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants