Use S3Client::upload instead of splitting single/multipart upload ourselves #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selves Signed-off-by: Robin Appelman <robin@icewind.nl>
|
Is it super urgent? Then we need to backport this as well for the RC3 (#8027) or we backport it to 13.0.1. |
|
13.0.1 should be fine in my eyes (setting 13 as milestone is mostly out of habit 🙈) |
This was referenced Jan 29, 2018
rullzer
approved these changes
Feb 8, 2018
MorrisJobke
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to do mostly the same checks but a bit more reliable.
Possible fix for #7585