-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the admin configure the default share permissions #7363
Conversation
@jancborchardt please have a look at the two screenshots above. What do you prefer? Or something complete different? (It is about the "default share permissions") |
Codecov Report
@@ Coverage Diff @@
## master #7363 +/- ##
============================================
+ Coverage 51.88% 51.89% +<.01%
- Complexity 25394 25396 +2
============================================
Files 1603 1603
Lines 95214 95249 +35
Branches 1379 1380 +1
============================================
+ Hits 49403 49427 +24
- Misses 45811 45822 +11
|
97db685
to
c09d4d9
Compare
Do we still want to stick to this complicated CRUD-mechanic? I thought at some point we only do two permissions:
|
Since Nextcloud 13 is out I think now it is the right time to pick this up, looking forward to your reviews |
First of all: looking forward for your merge conflict fixes 😜 😉 |
4fe6b04
to
50e9aab
Compare
@MorrisJobke done... now it is your turn 😉 |
What about my comment above? "Can edit", "Can reshare" should be the permissions, none other. |
@jancborchardt I think it is a bit out of context. I'm completely open for simplifying the permissions. But this is one is just about making the default permissions configurable. |
waiting for a second review... Would be great to get this finally in before we have to rebase it again and again. Thanks! |
@rullzer @nickvergessen @skjnldsv Review would be nice :) |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
fc1740c
to
20ec034
Compare
I rebased to make sure it all still works. Fails somehow. I'll look into the why.... |
Ah was just cached stuff. Works like a charm. |
Let the admin configure the default share permissions
Possible look:
or (currently implemented)