Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default permissions on sharebymail #8186

Closed
Cybso opened this issue Feb 5, 2018 · 2 comments
Closed

Change default permissions on sharebymail #8186

Cybso opened this issue Feb 5, 2018 · 2 comments
Milestone

Comments

@Cybso
Copy link

Cybso commented Feb 5, 2018

Please modify ShareByMailProvider.php to ignore 'permissions' for new shares but use PERMISSION_READ by default (method "createMailShare"), or add a configuration option to define a umask for new permissions.

The current behaviour is really unexpected (and possible dangerous) for users that are accustomed with other file sharing services like Dropbox or Google Drive. With this simple change the user would still be able to grant edit permission explicitly.

Steps to reproduce

  1. Create a new "share by mail"

Expected behaviour

The recipient can download the shared content, but is not able to modify it.

Actual behaviour

If the user doesn't pay attention the recipient is able to misuse the shared file or directory.

Server configuration

Doesn't matter.

@Cybso Cybso changed the title sharebymail Change default permissions on sharebymail Feb 6, 2018
Cybso pushed a commit to Cybso/server that referenced this issue Feb 6, 2018
See issue nextcloud#8186

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
@Cybso
Copy link
Author

Cybso commented Feb 7, 2018

There is another pull request with a more generic approach: #7363

@MorrisJobke
Copy link
Member

Fixed by #7363

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants