fix(user_ldap): Use %n in plural translation to avoid a crash in L10N #48028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
ArtificialOwl,
Altahrim and
artonge
and removed request for
a team
Closed
8 tasks
|
/backport to stable30 |
AndyScherzinger
approved these changes
Sep 15, 2024
susnux
approved these changes
Sep 15, 2024
| @@ -58,23 +58,23 @@ public function run(): SetupResult { | |||
| if (!empty($bindFailedConfigurations)) { | |||
| $output .= $this->l10n->n( | |||
| 'Binding failed for this LDAP configuration: %s', | |||
There was a problem hiding this comment.
should have added the %n here as well to help translators of non-"1/other" languages
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tested and works.
Checklist