Merge pull request #48028 from nextcloud/fix/fix-ldap-setupcheck-crash

fix(user_ldap): Use %n in plural translation to avoid a crash in L10N
nextcloud · Sep 16, 2024 · a6bd34e · a6bd34e
2 parents d6a59be + 317c4ba
commit a6bd34e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/apps/user_ldap/lib/SetupChecks/LdapConnection.php b/apps/user_ldap/lib/SetupChecks/LdapConnection.php
@@ -58,23 +58,23 @@ public function run(): SetupResult {
 		if (!empty($bindFailedConfigurations)) {
 			$output .= $this->l10n->n(
 				'Binding failed for this LDAP configuration: %s',
-				'Binding failed for these LDAP configurations: %s',
+				'Binding failed for %n LDAP configurations: %s',
 				count($bindFailedConfigurations),
 				[implode(',', $bindFailedConfigurations)]
 			)."\n";
 		}
 		if (!empty($searchFailedConfigurations)) {
 			$output .= $this->l10n->n(
 				'Searching failed for this LDAP configuration: %s',
-				'Searching failed for these LDAP configurations: %s',
+				'Searching failed for %n LDAP configurations: %s',
 				count($searchFailedConfigurations),
 				[implode(',', $searchFailedConfigurations)]
 			)."\n";
 		}
 		if (!empty($inactiveConfigurations)) {
 			$output .= $this->l10n->n(
 				'There is an inactive LDAP configuration: %s',
-				'There are inactive LDAP configurations: %s',
+				'There are %n inactive LDAP configurations: %s',
 				count($inactiveConfigurations),
 				[implode(',', $inactiveConfigurations)]
 			)."\n";
@@ -86,7 +86,7 @@ public function run(): SetupResult {
 		}
 		return SetupResult::success($this->l10n->n(
 			'Binding and searching works on the configured LDAP connection (%s)',
-			'Binding and searching works on all of the configured LDAP connections (%s)',
+			'Binding and searching works on all of the %n configured LDAP connections (%s)',
 			count($availableConfigs),
 			[implode(',', $availableConfigs)]
 		));