Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(previews): Don't crash on animated WEBP images #47080

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 6, 2024

Backport of PR #38364

Fixes #30029 and #37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny merged commit 1b50d28 into stable29 Aug 7, 2024
177 checks passed
@st3iny st3iny deleted the backport/38364/stable29 branch August 7, 2024 08:16
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants