Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request thumbnail function of animated webp file #37263

Closed
ytoaa opened this issue Mar 16, 2023 · 3 comments
Closed

Request thumbnail function of animated webp file #37263

ytoaa opened this issue Mar 16, 2023 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: previews and thumbnails

Comments

@ytoaa
Copy link

ytoaa commented Mar 16, 2023

A typical single image webp file displays a normal thumbnail. However, the thumbnail display is not suitable for the animated webp file. The gif file is a moving file, but the first frame is displayed as a thumbnail.
When accessing the animation webp, the thumbnail is not displayed because of the error " PHP Fatal error: gd-webp cannot allocate temporary buffer in /var/www/html/lib/private/legacy/OC_Image.php on line 722 . "

@ytoaa ytoaa added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 16, 2023
@ytoaa ytoaa changed the title Request thumbnail function of animation webp file Request thumbnail function of animated webp file Mar 16, 2023
@joshtrichards
Copy link
Member

This is an upstream matter:

libgd/libgd#648
https://bugs.php.net/bug.php?id=79809
https://www.php.net/manual/en/function.imagecreatefromwebp.php

We could, perhaps, detect if it is an animated webp beforehand, but the end result in terms of user experience would be the same (no thumbnail).

If you think there's a reasonable spot for documenting this current situation in the official NC documentation, feel to post a suggestion (or even better a PR) over at https://github.com/nextcloud/documentation

Nothing to do here otherwise. When (or if) support is added upstream it'll probably start to "just work". :)

@joshtrichards

This comment was marked as resolved.

joshtrichards added a commit to joshtrichards/nc-server that referenced this issue May 18, 2023
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member

Duplicate of #30029.

Please subscribe to #30029 if you wish to track progress.

@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue Mar 9, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue Apr 4, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue May 27, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue May 27, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue May 29, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards added a commit to joshtrichards/nc-server that referenced this issue May 29, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
st3iny pushed a commit to joshtrichards/nc-server that referenced this issue May 30, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
backportbot bot pushed a commit that referenced this issue Aug 6, 2024
Fixes #30029 and #37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
backportbot bot pushed a commit that referenced this issue Aug 6, 2024
Fixes #30029 and #37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
src-r-r pushed a commit to src-r-r/nextcloud-server that referenced this issue Aug 9, 2024
Fixes nextcloud#30029 and nextcloud#37263

libgd handles animated WEBP images poorly and generates a meaningless error message as a result. We were returning a 500 error for these preview requests (web) and a fatal error at the command-line (occ). Now we bypass libgd if the we detect an animated WEBP image (and simply don't generate the preview). No more 500 error. Should fix occ too.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: previews and thumbnails
Projects
None yet
Development

No branches or pull requests

2 participants