-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor app & account management UI code #44092
Conversation
a411cb2
to
58595d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great PR, loved seeing typeof === 'undefined'
👀
apps/settings/src/components/AppStoreSidebar/AppReleasesTab.vue
Outdated
Show resolved
Hide resolved
58595d4
to
cbad56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szaimen I fully agree, this is a leftover from the old / current design. But I would really like to do that in a follow up. This PR is already too huge. Is that ok for you? |
yes, fine for me. Shall I create an issue so that it doesnt get lost or do you want? |
I will do |
cbad56f
to
7be174e
Compare
7be174e
to
68c63f8
Compare
68c63f8
to
bc1a3bd
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The should ease the maintenance of it due to reduced complexity. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
bc1a3bd
to
fc73bd0
Compare
I've just upgraded Nextcloud to 28.0.4 but the bug on Safari is still present. |
Summary
apps.nextcloud.com
apps.nextcloud.com
that got a recent design overhaul.Screenshots
Checklist