Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Icon of menu entry "Dashboard" in Apps section remains black in dark mode #42803

Closed
5 of 8 tasks
luddinho opened this issue Jan 15, 2024 · 6 comments · Fixed by #44092
Closed
5 of 8 tasks

[Bug]: Icon of menu entry "Dashboard" in Apps section remains black in dark mode #42803

luddinho opened this issue Jan 15, 2024 · 6 comments · Fixed by #44092
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: apps management

Comments

@luddinho
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Inside the Apps menu the icon of entry "Dashboard" remains black when switching to dark mode.

SCR-20240115-nfjr SCR-20240115-nfrj

Nextcloud Sever: 27.1.5
Apache 2.4
PHP 8.2

Steps to reproduce

  1. Open Apps section
  2. The icon of menu item "Dashboard" is always black
  3. Switch between light and dark mode, icon of Dashboard remains black

Expected behavior

The icon shall switch its color to white when dark mode is enabled.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.19.0
  - calendar: 4.6.3
  - checksum: 1.2.3
  - circles: 27.0.1
  - cloud_federation_api: 1.10.0
  - comments: 1.17.0
  - contacts: 5.5.1
  - dav: 1.27.0
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_external: 1.19.0
  - files_pdfviewer: 2.8.0
  - files_reminders: 1.0.0
  - files_rightclick: 1.6.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - firstrunwizard: 2.16.0
  - forms: 3.4.4
  - logreader: 2.12.0
  - lookup_server_connector: 1.15.0
  - nextcloud_announcements: 1.16.0
  - notifications: 2.15.0
  - oauth2: 1.15.1
  - password_policy: 1.17.0
  - photos: 2.3.0
  - polls: 5.4.2
  - privacy: 1.11.0
  - provisioning_api: 1.17.0
  - quota_warning: 1.18.0
  - recommendations: 1.6.0
  - related_resources: 1.2.0
  - serverinfo: 1.17.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - side_menu: 3.11.2
  - spreed: 17.1.4
  - survey_client: 1.15.0
  - systemtags: 1.17.0
  - text: 3.8.0
  - theming: 2.2.0
  - twofactor_backupcodes: 1.16.0
  - twofactor_totp: 9.0.0
  - twofactor_webauthn: 1.3.2
  - updatenotification: 1.17.0
  - viewer: 2.1.0
  - workflowengine: 2.9.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@luddinho luddinho added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 15, 2024
@theTyster
Copy link
Contributor

Can this be closed? I am not seeing this issue in 28.0.3. or on the master branch anymore.

dark theme image

@luddinho
Copy link
Author

luddinho commented Mar 8, 2024

I have updated my Test Instance to 28.0.3, but the issue still exists on my side.
From my point of view this issue cannot be closed.

Bildschirmaufnahme.2024-03-08.um.15.41.18.mov

@theTyster
Copy link
Contributor

theTyster commented Mar 8, 2024

hmm tricky...

@luddinho What browser are you using?

Also, how are you setting the dark theme? In that video you toggle the theme. But in the view you are looking at, there is nowhere on the screen to change the theme.

@luddinho
Copy link
Author

luddinho commented Mar 8, 2024

I'm using Microsoft Edge as default browser on my system.

The dark Theme is set to follow the system standard.
image

And for switching the system standard I'm using Nightfall on Mac OS with an keyboard shortcut. Therefore you are not able to see any action from the screen record.

But now I can confirm that with a different browser than MS Edge the icon appears correct in white when using dark mode.

Please take a look on the new screen record.
Browsers that have been used (from left to the right): MS Edge, Chrome, Safari

Bildschirmaufnahme.2024-03-08.um.20.10.46.mov

Uhh yeah very crazy. It seems that only MS Edge behaves wrong!
I will additionally do the same comparison with another Nextcloud instance on 27.1.7 to check if also MS Edge will be responsible for that issue.

I will inform you about the result.

@luddinho
Copy link
Author

luddinho commented Mar 8, 2024

The result with Nextcloud 27.1.7
All browsers (MS Edge, Chrome, Safari) behave incorrectly in dark mode in this version.

Bildschirmaufnahme.2024-03-08.um.20.36.47.mov

@susnux
Copy link
Contributor

susnux commented Mar 10, 2024

Probably duplicate of #42998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: apps management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants