Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(request): Handle reverse proxy setting a port in Forwarded-For #43552

Merged
merged 4 commits into from
Feb 15, 2024
Merged

fix(request): Handle reverse proxy setting a port in Forwarded-For #43552

merged 4 commits into from
Feb 15, 2024

Conversation

nickvergessen
Copy link
Member

Checklist

Mika56 and others added 3 commits February 13, 2024 16:51
@Mika56 @nickvergessen
fix(request): Handle reverse proxy setting a port in Forwarded-For
ffcadf2 
Signed-off-by: Mikael Peigney <Mika56@users.noreply.github.com>
@nickvergessen
test(request): Add tests to strip the port when forwarding requests
9ed3ab7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(request): Fix regex handling and coding-style
c468408 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Feb 13, 2024
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Feb 13, 2024
@nickvergessen nickvergessen requested a review from a team February 13, 2024 15:52
@nickvergessen nickvergessen self-assigned this Feb 13, 2024
@nickvergessen nickvergessen requested review from ArtificialOwl, blizzz and Fenn-CS and removed request for a team February 13, 2024 15:52
@nickvergessen nickvergessen mentioned this pull request Feb 13, 2024
Closed
blizzz
blizzz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs code style fixes

@nickvergessen
fix(CS): Fix coding style
696ed4a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 9f38aab into master Feb 15, 2024
159 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/rfc7239-compatible-proxy-handling branch February 15, 2024 14:29
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @bigcat88 @Mika56