Handle reverse proxy setting a port in Forwarded-For

[Mika56]

As per RFC 7239, a reverse proxy may add a port to the client's IP address:

If the server receiving proxied requests requires some
address-based functionality, this parameter MAY instead contain an IP
address (and, potentially, a port number)
https://datatracker.ietf.org/doc/html/rfc7239.html#section-5.2:~:text=and%2C%20potentially%2C%20a%20port%20number

This MR removes that port from the IP address, allowing the Forwarde-For header to be properly handled.

[nickvergessen]

this completely breaks IPv6

[Mika56]

Nice catch. I've updated the PR with new code that should work better

[kesselb]

As reference, how Symfony solved the same problem: https://github.com/symfony/symfony/blob/d9d6024a1a663caa7f13360a4a1d9de443e9c954/src/Symfony/Component/HttpFoundation/Request.php#L1986-L1997

I recommend adding some automated tests to make sure the parsing does not break in the future.

[Mika56]

And the corresponding tests: https://github.com/symfony/symfony/blob/d9d6024a1a663caa7f13360a4a1d9de443e9c954/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php#L1034
Should we use their test suite? I don't see support for [IPv6]:port
Would that be adding a file to tests/lib/AppFramework/Http ?

[nickvergessen]

You can add your tests in

server/tests/lib/AppFramework/Http/RequestTest.php

Line 552 in 216b95f

public function testGetRemoteAddressWithoutTrustedRemote() {

[nickvergessen]

Do you need more help? Or shall we take over to finish it?

[Mika56]

I lack time, if you're willing to take it over, please go for it! :)

[nickvergessen]

Due to changes in CI a rebase was required, but I was unable to push that. So I made a new PR at #43552

[Mika56]

No problem, thanks for taking care of it!