Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] feat(theming): Only convert a background image if it benefits from it #42943

Merged
merged 3 commits into from
Jan 19, 2024

fix(themeing): Add error handling to ImageManager

a2a8555
Select commit
Loading
Failed to load commit list.
Merged

[stable25] feat(theming): Only convert a background image if it benefits from it #42943

fix(themeing): Add error handling to ImageManager
a2a8555
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm succeeded Jan 18, 2024 in 3s

12 new alerts

New alerts in code changed by this pull request

  • 12 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 250 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyFalseOperand Note

Left operand cannot be falsable, got false|int

Check notice on line 250 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyFalseOperand Note

Left operand cannot be falsable, got false|int

Check notice on line 257 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 1 of imageinterlace expects resource, possibly different type resource|true provided

Check notice on line 269 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 1 of imagedestroy expects resource, possibly different type resource|true provided

Check notice on line 271 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

DocblockTypeContradiction Note

Cannot resolve types for $outputImage - docblock-defined type resource|true does not contain GdImage

Check notice on line 271 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyUndefinedVariable Note

Possibly undefined variable $outputImage defined in try block

Check notice on line 271 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyUndefinedVariable Note

Possibly undefined variable $outputImage defined in try block

Check notice on line 271 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

DocblockTypeContradiction Note

Cannot resolve types for $outputImage - docblock-defined type true does not contain GdImage

Check notice on line 272 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 1 of imagedestroy expects resource, possibly different type GdImage|resource provided

Check notice on line 275 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\ILogger::debug has been marked as deprecated

Check notice on line 260 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 1 of imagejpeg expects resource, possibly different type resource|true provided

Check notice on line 264 in apps/theming/lib/ImageManager.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyInvalidArgument Note

Argument 1 of imagepng expects resource, possibly different type resource|true provided