Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] feat(theming): Only convert a background image if it benefits from it #42943

Merged
merged 3 commits into from
Jan 19, 2024
Merged

[stable25] feat(theming): Only convert a background image if it benefits from it #42943

merged 3 commits into from
Jan 19, 2024

Commits on Jan 18, 2024

  1. feat(theming): Only convert a background image if it benefits from it 

    * WebP images are generally quite small, converting to pngs would increase
  the filesize a lot.
* Small JPEG and PNG images do not benefit from any conversion, so skip it.
* JPEG images will get quite bigger when converted to PNG so instead convert to progressive JPEG

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux @backportbot-nextcloud
    susnux authored and backportbot-nextcloud[bot] committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5e881ac View commit details
    Browse the repository at this point in the history

  2. Add webp and large jpg test assets 

    Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux @backportbot-nextcloud
    susnux authored and backportbot-nextcloud[bot] committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    00db3c2 View commit details
    Browse the repository at this point in the history

  3. fix(themeing): Add error handling to ImageManager 

    Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux @backportbot-nextcloud
    susnux authored and backportbot-nextcloud[bot] committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a2a8555 View commit details
    Browse the repository at this point in the history