Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip outside click, should abort share creation #42126

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Tooltip outside click, should abort share creation #42126

merged 3 commits into from
Dec 12, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Dec 8, 2023 •
edited
Loading

  • It's unexpected that click outside a tooltip would proceed with the action that could be carried out inside the tooltip.
  • Allow user to finish typing date before formatting

Resolves : #42046, #42114

@Fenn-CS Fenn-CS marked this pull request as draft December 8, 2023 16:24
@Fenn-CS Fenn-CS marked this pull request as ready for review December 8, 2023 17:06
@Fenn-CS Fenn-CS force-pushed the click-outside-should-abort-share branch from c591790 to 98ee9d6 Compare December 8, 2023 17:07
@Fenn-CS Fenn-CS linked an issue Dec 8, 2023 that may be closed by this pull request
[Bug]: Click outside dropdown still create public share #42114
Closed
8 tasks
artonge
artonge requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files seem unrelated

apps/files_trashbin/tests/js/appSpec.js Outdated Show resolved Hide resolved
@Fenn-CS
Tooltip outside click, should abort share creation
c179408 
It's unexpected that click outside a tooltip would proceed with the
 action that could be carried out inside the tooltip.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the click-outside-should-abort-share branch from 98ee9d6 to 41061dd Compare December 11, 2023 20:03
@Fenn-CS
Allow user to finish typing date before formatting
04e8733 
Debounce `onExpirationChange` to avoid calling `formatDateToString`
on invalid on uncompletely inputed date strings.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the click-outside-should-abort-share branch from 41061dd to 04e8733 Compare December 11, 2023 20:06
@Fenn-CS Fenn-CS requested a review from artonge December 11, 2023 20:08
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 11, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
4f98b78 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 6c482bc into master Dec 12, 2023
42 checks passed
@susnux susnux deleted the click-outside-should-abort-share branch December 12, 2023 19:29
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 12, 2023

/backport to stable28

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 12, 2023

/backport to stable27

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 13, 2023

/backport to stable28

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Dec 13, 2023

/backport to stable27

@skjnldsv
Copy link
Member

/skjnldsv-backport c179408 04e8733 to stable28

@backportbot backportbot bot mentioned this pull request Jan 15, 2024
Merged
1 task
@skjnldsv
Copy link
Member

/skjnldsv-backport c179408 04e8733 to stable27

@backportbot backportbot bot mentioned this pull request Jan 15, 2024
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: sharing
Projects
📁 Files team
Archived in project
Milestone
No milestone
5 participants
@Fenn-CS @skjnldsv @susnux @artonge @nextcloud-command