[stable25] fix(caldav): harden null handling of iMip scheduling method #39591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
5 tasks
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| @@ -177,7 +177,7 @@ | |||
| $iTipMessage->scheduleStatus = '5.0; EMail delivery failed'; | |||
| return; | |||
| } | |||
| $recipientName = $iTipMessage->recipientName ?: null; | |||
| $recipientName = $iTipMessage->recipientName ? (string)$iTipMessage->recipientName : null; | |||
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
tcitworld
approved these changes
Jul 27, 2023
ChristophWurst
approved these changes
Jul 27, 2023
st3iny
added
4. to release
|
Test failures seem unrelated (acceptance-users). |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
kesselb
force-pushed
the
backport/stable25/fix/noid/imip-plugin-null-hardening
branch
from
9a54b32
to
d66cf1e
Compare
Merged
blizzz
changed the title
blizzz
deleted the
backport/stable25/fix/noid/imip-plugin-null-hardening
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Manual backport of #36935
TODO
Checklist