-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(caldav): harden null handling of iMip scheduling method #36935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
Waiting for reviews
feature: caldav
Related to CalDAV internals
labels
Mar 1, 2023
st3iny
force-pushed
the
fix/noid/imip-plugin-null-hardening
branch
2 times, most recently
from
March 1, 2023 12:42
26a906b
to
5a47ed6
Compare
ChristophWurst
approved these changes
Mar 1, 2023
nickvergessen
approved these changes
Mar 1, 2023
Could we extend the tests? |
/rebase |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
nextcloud-command
force-pushed
the
fix/noid/imip-plugin-null-hardening
branch
from
March 2, 2023 09:42
5a47ed6
to
a35b960
Compare
/backport to stable25 |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
6 tasks
Backport for stable25: #39591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The schedule() method of the iMip plugin poorly handles various null values. I hardened it a bit to prevent further breakage in the future.
This PR can be tested using the following patch:
TODO
Checklist