Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label for logo link #37435

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add label for logo link #37435

merged 1 commit into from
Mar 30, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 28, 2023 •
edited
Loading

Summary

Add a descriptive label for the logo link
image

To be backported to stable25 for accessibility

TODO

  • Remove extraneous span translated string
  • Fix label when going to logoUrl
  • Translate app name
  • Fix existing tests
  • Add tests

Checklist

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Mar 28, 2023
@Pytal Pytal added this to the Nextcloud 27 milestone Mar 28, 2023
@Pytal Pytal self-assigned this Mar 28, 2023
@Pytal Pytal mentioned this pull request Mar 28, 2023
Closed
4 tasks
@Pytal
Copy link
Member Author

Pytal commented Mar 28, 2023

/backport to stable26

@Pytal
Copy link
Member Author

Pytal commented Mar 28, 2023

/backport to stable25

@Pytal Pytal mentioned this pull request Mar 28, 2023
Closed
11 tasks
skjnldsv
skjnldsv reviewed Mar 28, 2023
View reviewed changes
lib/private/App/AppManager.php
$user ??= $this->userSession->getUser();

if ($user !== null) {
$userDefaultApps = explode(',', $this->config->getUserValue($user->getUID(), 'core', 'defaultapp'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultapp ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to be updatable from the web UI but added in db86bea probably for admins to set with

occ user:setting admin core defaultapp files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually support users setting their own default app?
Also my main concern was more about the string itself. What does "defaultApp" refers too? There is no app named like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually support users setting their own default app?

Can only be set by an admin from what I can see

Also my main concern was more about the string itself. What does "defaultApp" refers too? There is no app named like that?

Probably thought the string was the default fallback? 'defaultapp' is actually passed as the key argument for

server/lib/public/IConfig.php

Line 196 in 31f4f41

public function getUserValue($userId, $appName, $key, $default = '');

come-nc
come-nc approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from skjnldsv comments.

lib/public/App/IAppManager.php Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the enh/a11y-logo-label branch 3 times, most recently from ca9e361 to 7c6ffd9 Compare March 28, 2023 23:24
@Pytal Pytal requested a review from skjnldsv March 28, 2023 23:28
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested different scenarios and it works! Thank you

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 29, 2023
@Pytal
Add label for logo link
4f8e916 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal merged commit 63b90d4 into master Mar 30, 2023
@Pytal Pytal deleted the enh/a11y-logo-label branch March 30, 2023 00:22
This was referenced Mar 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @skjnldsv @come-nc