[BITV] 9.1.1.1a/2.1 - The Nextcloud logo (link) does not have an alternative text. A suitable alternative text could be "Nextcloud - Go to dashboard." (9)

[AndyScherzinger]

• Add label for logo link #37435
• [stable26] Add label for logo link #37471
• [stable25] Add label for logo link #37472

1. Original fix/approach from Add alt to the logo, adapt css for logo #35071 had to be reverted.
2. Please discuss and align the new approach with @skjnldsv to ensure theming won't break.

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v2-n1

• 9.1.1.1a/3.5 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v3-n5
• 9.1.1.1a/4.1 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v4-n1
• 9.1.1.1a/5.3 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v5-n3
• 9.1.1.1a/6.2 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v6-n2
• 9.1.1.1a/7.2 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v7-n2
• 9.1.1.1a/8.1 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v8-n1
• 9.1.1.1a/9.2 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v9-n2
• 9.1.1.1a/10.5 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-cd239865a5-v10-n5

[JuliaKirschenheuter]

@michaelnissenbaum It is actually not easy to set a detailed name for the logo-link because a link for the logo is configurable in:

server/config/config.sample.php

Lines 224 to 233 in dde5c46

	/**
	* Set the default app to open on login. Use the app names as they appear in the
	* URL after clicking them in the Apps menu, such as documents, calendar, and
	* gallery. You can use a comma-separated list of app names, so if the first
	* app is not enabled for a user then Nextcloud will try the second one, and so
	* on. If no enabled apps are found it defaults to the dashboard app.
	*
	* Defaults to ``dashboard,files``
	*/
	'defaultapp' => 'dashboard,files',

This means it depends on the config and on user access/rights which link is available for a current user.

For now the implementation looks like this which always says "(name of the nextcloud instance) homepage", whatever the current homepage is:

Could we move on with this solution?
Thank you!

[skjnldsv]

The logo is irrelevant here. It should be treated as a decorative image.
What is important is the aria description of the link. You can edit this and have access to the defaultapp config with php.
Then use it to inject the proper aria attributes in the user template

server/core/templates/layout.user.php

Line 61 in 0d67fc2

<a href="<?php print_unescaped($_['logoUrl'] ?: link_to('', 'index.php')); ?>"

Where to compute and pass variables to the template:

server/lib/private/TemplateLayout.php

Lines 122 to 124 in 0d67fc2

	// set logo link target
	$logoUrl = $this->config->getSystemValueString('logo_url', '');
	$this->assign('logoUrl', $logoUrl);

[JuliaKirschenheuter]

Hi @skjnldsv

Thank you for your suggesting. I've tried to implement it this way. But the thing is: "if the first app is not enabled for a user then Nextcloud will try the second one, and so on." I have no idea how to implement it in dynamic way. I mean: for example:

config.php: 'defaultapp' => 'mail,dashboard,files',
For user A is mail app enabled, for user B not.
How should i deal it?

And how could i check in general if an app is enabled or not?

[skjnldsv]

Extract the logic from

server/lib/private/URLGenerator.php

Lines 302 to 338 in 71f6986

	public function linkToDefaultPageUrl(): string {
	// Deny the redirect if the URL contains a @
	// This prevents unvalidated redirects like ?redirect_url=:user@domain.com
	if (isset($_REQUEST['redirect_url']) && strpos($_REQUEST['redirect_url'], '@') === false) {
	return $this->getAbsoluteURL(urldecode($_REQUEST['redirect_url']));
	}
	$defaultPage = $this->config->getAppValue('core', 'defaultpage');
	if ($defaultPage) {
	return $this->getAbsoluteURL($defaultPage);
	}
	$appId = 'files';
	$defaultApps = explode(',', $this->config->getSystemValue('defaultapp', 'dashboard,files'));
	$userId = $this->userSession->isLoggedIn() ? $this->userSession->getUser()->getUID() : null;
	if ($userId !== null) {
	$userDefaultApps = explode(',', $this->config->getUserValue($userId, 'core', 'defaultapp'));
	$defaultApps = array_filter(array_merge($userDefaultApps, $defaultApps));
	}
	// find the first app that is enabled for the current user
	foreach ($defaultApps as $defaultApp) {
	$defaultApp = \OC_App::cleanAppId(strip_tags($defaultApp));
	if (\OC::$server->getAppManager()->isEnabledForUser($defaultApp)) {
	$appId = $defaultApp;
	break;
	}
	}
	if ($this->config->getSystemValue('htaccess.IgnoreFrontController', false) === true
	|| getenv('front_controller_active') === 'true') {
	return $this->getAbsoluteURL('/apps/' . $appId . '/');
	}
	return $this->getAbsoluteURL('/index.php/apps/' . $appId . '/');
	}

And create a method to get the default AppId somewhere it make sense (Maybe User.php ? 🤷 )