Correct the name of logo #36876
Closed
Correct the name of logo #36876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
|
/backport to stable25 |
artonge
approved these changes
Feb 27, 2023
| @@ -62,7 +62,7 @@ | |||
| id="nextcloud"> | |||
| <div class="logo logo-icon"> | |||
| <span class="hidden-visually"> | |||
| <?php p($l->t('%s homepage', [$theme->getName()])); ?> | |||
| <?php p($l->t('%s - go to dashboard', [$theme->getName()])); ?> | |||
There was a problem hiding this comment.
It's not always the dashboard. The app this links to is actually configurable for admins.
server/config/config.sample.php
Lines 224 to 233 in dde5c46
|
This PR makes no sense anymore because a right implementation would take to much time, see #36876 (comment). Closing issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correct the name of logo to "Nextcloud - go to dashboard".
Structure:
Checklist