Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Remove comment and guests option from Invitations UI #35863

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35761

Signed-off-by: Anna Larch <anna@nextcloud.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug feature: caldav Related to CalDAV internals pending documentation This pull request needs an associated documentation update labels Dec 22, 2022
@PVince81
Copy link
Member

23 is EOL, is this a critical fix ?

@blizzz blizzz merged commit c1778cf into stable23 Jan 17, 2023
@blizzz blizzz deleted the backport/35761/stable23 branch January 17, 2023 10:13
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: caldav Related to CalDAV internals pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants