Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment and guests option from Invitations UI #35761

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Dec 13, 2022

Summary

Sabre doesn't support comments and guests. As such, these values are never passed on to the backend and are never stored anywhere. For the moment, the only solution is to remove the option completely.

Checklist

@miaulalala miaulalala self-assigned this Dec 13, 2022
@miaulalala miaulalala added bug 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update feature: caldav Related to CalDAV internals labels Dec 13, 2022
@miaulalala
Copy link
Contributor Author

/backport to stable25

@miaulalala
Copy link
Contributor Author

/backport to stable24

@miaulalala
Copy link
Contributor Author

/backport to stable23

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 20, 2022
@PVince81
Copy link
Member

/rebase

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
Copy link
Contributor Author

Drone failure is our old friend files sharing acceptance

@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'pending documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar invitation response (guests and comment) not processed
5 participants