-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ExternalShareActions API #28835
Conversation
/backport to stable22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Too bad the files_downloadlimit
example does not work (yet 😁).
I'll make some real life tests by registering another component soon.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
adf7856
to
2213358
Compare
This comment has been minimized.
This comment has been minimized.
5413a9e
to
b1572c9
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
b1572c9
to
cbe406e
Compare
See example:
nextcloud/files_downloadlimit#5
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/main.js
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/models/DownloadLimitAction.js
This API is a more global way of injecting entries into the link share menu.
It can be any type currently supported by the vue components.
In opposite of the old (and now legacy deprecated) API that only allowed links (for the social app).