Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App defined share permission flags #22220

Open
juliusknorr opened this issue Aug 12, 2020 · 6 comments
Open

App defined share permission flags #22220

juliusknorr opened this issue Aug 12, 2020 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing

Comments

@juliusknorr
Copy link
Member

Moved over from #12178 (comment) since this recently came up again with ONLYOFFICE.

There are several use-cases where apps like Collabora or OnlyOffice could provide additional sharing permissions.

OnlyOffice (https://api.onlyoffice.com/editors/config/document/permissions):

  • Can fill forms
  • Can review
  • Can comment
  • Can print (would be covered by hide download)
  • Can download (would be covered by hide download)
  • Can edit (would be covered by regular permissions)

Collabora has quite fine granular options to set (DisableCopy, DisableExport, HidePrintOption, HideSaveOption, HideExportOption, UserCanWrite) but I think we do fine by just using our current hide download/read/write permissions for those. However in the future there also might be options similar to the ones in OnlyOffice.

Edit: It should be possible for apps to limit the availability of permissions like https://api.onlyoffice.com/editors/faq/sharing

Additional options that might be possible for link shares:

  • Watermark file (only makes sense for hide download links, as otherwise you can always just download the regular file), so I think it's fine to not expose this as an additional permission

My proposal would be to allow apps adding custom permission flags that can either be true or false and then would be added to the additional settings

I've also did some quick mockups to make the menu restructuring a bit clearer:
image

Additional permissions would then pile up under the Can delete, only if the shared mime type would support them of course.

@juliusknorr juliusknorr added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Aug 12, 2020
@juliusknorr
Copy link
Member Author

@nextcloud/sharing @nextcloud/designers

@rullzer
Copy link
Member

rullzer commented Aug 13, 2020

So (API wise aside etc). You are suggesting to have an extra field in the share table. And store some JSON thing there with a couple of bools?

Should be fine in my opinion.

@juliusknorr
Copy link
Member Author

So (API wise aside etc). You are suggesting to have an extra field in the share table. And store some JSON thing there with a couple of bools?

Either that or we have a extended share permission table that we can then query if needed only

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of feature: sharing and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 8, 2021
@skjnldsv
Copy link
Member

@jancborchardt fixed witht he concept of the new sharing ui, right?

@juliusknorr
Copy link
Member Author

No that would be a new feature that gets requested from time to time to give a more granular permission options is specific collaborative editing solutions like ONLYOFFICE or Collabora Online.

@juliusknorr
Copy link
Member Author

Backend API is introduced with #32482

Frontend would need a similar API as #28835 with additional handling of the attribute registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

4 participants