Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set openfile params when following internal links #28174

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Set openfile params when following internal links #28174

merged 2 commits into from
Jul 28, 2021

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 26, 2021 •
edited
Loading

Extend #27102 to internal links to improve share experience.

@artonge artonge changed the title feature/set_openfile_for_internal_links Set openfile params when following internal links Jul 26, 2021
juliusknorr
juliusknorr approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@artonge
Copy link
Contributor Author

artonge commented Jul 27, 2021

/rebase

@artonge
Set openfile params when following internal links
e558a00 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@github-actions github-actions bot force-pushed the feature/set_openfile_for_internal_links branch from bb2c52d to e558a00 Compare July 27, 2021 11:41
@skjnldsv
Copy link
Member

backport?

This was referenced Jul 27, 2021
Merged
Merged
Merged
@artonge
Copy link
Contributor Author

artonge commented Jul 27, 2021

/backport to stable22

@artonge
Copy link
Contributor Author

artonge commented Jul 27, 2021

/backport to stable21

@artonge
Copy link
Contributor Author

artonge commented Jul 27, 2021

/backport to stable20

@artonge @Pytal
Fix typo
1ad5e8a 
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 28, 2021
@skjnldsv skjnldsv merged commit 3ced840 into master Jul 28, 2021
@skjnldsv skjnldsv deleted the feature/set_openfile_for_internal_links branch July 28, 2021 13:03
This was referenced Jul 28, 2021
Merged
Closed
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 28, 2021
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 10, 2021
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @skjnldsv @juliusknorr @Pytal