-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger the default action when openfile URL param is set #27102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
2 times, most recently
from
May 25, 2021 16:45
fc03ede
to
778aa49
Compare
skjnldsv
reviewed
May 26, 2021
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
10 times, most recently
from
May 31, 2021 17:04
50aa0ba
to
3158b22
Compare
1 task
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
3 times, most recently
from
June 1, 2021 13:43
9a7aad8
to
64f4822
Compare
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
4 times, most recently
from
June 8, 2021 08:06
5a2eb57
to
b4464a7
Compare
skjnldsv
reviewed
Jun 8, 2021
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
from
June 8, 2021 12:35
b4464a7
to
e73f060
Compare
artonge
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jun 8, 2021
juliusknorr
reviewed
Jun 9, 2021
juliusknorr
reviewed
Jun 9, 2021
juliusknorr
reviewed
Jun 9, 2021
juliusknorr
reviewed
Jun 9, 2021
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
2 times, most recently
from
June 9, 2021 08:11
a6de771
to
2283d6a
Compare
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
4 times, most recently
from
June 9, 2021 13:16
b16b7cf
to
206ddb1
Compare
ChristophWurst
approved these changes
Jun 9, 2021
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
from
June 9, 2021 14:14
206ddb1
to
ddd0646
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
feature/auto_trigger_click_on_load
branch
from
June 9, 2021 14:19
ddd0646
to
c03a149
Compare
artonge
changed the title
Trigger the default action when scrollTo is set
Trigger the default action when openfile URL param is set
Jun 9, 2021
juliusknorr
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works with Text (viewer) and Collabora files 👍
This was referenced Jul 26, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back:
openfile
URL param is present to add an initial state object calledopenFileInfo
.openfile
URL param.Front
openfile
URL param inapp.js
.openfile
URL param in the initialization step ofFileList
so it does not wait for full rendering.isFullScreen
property toSidebar.vue
setFullScreenMode
method:OCA.Files.Sidebar.setFullScreenMode(true/false)
--full
css modifier from theViewer.vue
toSidebar.vue
dir
andid
guessing in default action for foldersFix #27100