Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the default action when openfile URL param is set #27102

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 25, 2021

Back:

  • Add a condition when the openfile URL param is present to add an initial state object called openFileInfo.
  • Change the file search provider to add the openfile URL param.

Front

  • Add propagation of the openfile URL param in app.js.
  • Move the handling of the openfile URL param in the initialization step of FileList so it does not wait for full rendering.
  • Add API to render the Sidebar in fullscreen:
    • Add the isFullScreen property to Sidebar.vue
    • Add and expose the setFullScreenMode method: OCA.Files.Sidebar.setFullScreenMode(true/false)
    • Repatriate the --full css modifier from the Viewer.vue to Sidebar.vue
  • Improve dir and id guessing in default action for folders

Fix #27100

@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 2 times, most recently from fc03ede to 778aa49 Compare May 25, 2021 16:45
@artonge artonge marked this pull request as ready for review May 25, 2021 16:48
@artonge artonge requested a review from skjnldsv May 25, 2021 16:49
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone May 26, 2021
@skjnldsv skjnldsv added the high label May 26, 2021
apps/files/js/filelist.js Outdated Show resolved Hide resolved
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 10 times, most recently from 50aa0ba to 3158b22 Compare May 31, 2021 17:04
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 3 times, most recently from 9a7aad8 to 64f4822 Compare June 1, 2021 13:43
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 4 times, most recently from 5a2eb57 to b4464a7 Compare June 8, 2021 08:06
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch from b4464a7 to e73f060 Compare June 8, 2021 12:35
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 8, 2021
@artonge artonge requested a review from skjnldsv June 8, 2021 16:42
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 2 times, most recently from a6de771 to 2283d6a Compare June 9, 2021 08:11
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch 4 times, most recently from b16b7cf to 206ddb1 Compare June 9, 2021 13:16
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch from 206ddb1 to ddd0646 Compare June 9, 2021 14:14
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feature/auto_trigger_click_on_load branch from ddd0646 to c03a149 Compare June 9, 2021 14:19
@artonge artonge changed the title Trigger the default action when scrollTo is set Trigger the default action when openfile URL param is set Jun 9, 2021
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with Text (viewer) and Collabora files 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open the sidebar on scrollTo, and directly trigger the default action from search results
4 participants