Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default max_chunk_size for files app to 100MB #26978

Closed
wants to merge 1 commit into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 13, 2021

fix #26977
Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added enhancement 3. to review Waiting for reviews performance 🚀 pending documentation This pull request needs an associated documentation update labels May 13, 2021
@szaimen szaimen added this to the Nextcloud 22 milestone May 20, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@blizzz
Copy link
Member

blizzz commented Jun 2, 2021

it's a low default to work with server limits, I would keep it that way tbh. The config can always be changed by the admin who knwis their environment.

@szaimen
Copy link
Contributor Author

szaimen commented Jun 2, 2021

Okay 👍

@szaimen szaimen closed this Jun 2, 2021
@szaimen szaimen deleted the enh/raise-default-chunk-size branch June 2, 2021 18:12
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jul 5, 2021
@devnoname120
Copy link

devnoname120 commented Apr 28, 2022

it's a low default to work with server limits, I would keep it that way tbh. The config can always be changed by the admin who knwis their environment.

@blizzz Do we have evidence that 10 MB is a reasonable server limit?
I see countless of threads of people on internet complaining that their uploads are slow. But they don't have the necessary technical expertise to link it to chunk size.

Why not set the default to something like 1 GB and let people with rare server limits change the configuration?

@blizzz
Copy link
Member

blizzz commented Apr 28, 2022

When admins can configure their webserver and PHP, they can also increase the chunk size. When other admins have only limited access and need to leave with default values by their hoster they cannot and might not even have access to the occ utility.

@devnoname120
Copy link

@blizzz What would you think about setting the default to auto and calling this function to determine the max upload size?

<?php
$default_max_chunk_size = ini_get('upload_max_filesize');

if ($default_max_chunk_size === false) {
	$default_max_chunk_size = 10 * 1024 * 1024;
}

This wouldn't work for misconfigured apache/nginx servers though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default max_chunk_size for files app to 100MB
4 participants