Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default max_chunk_size to 1 GB #32208

Closed
devnoname120 opened this issue Apr 28, 2022 · 5 comments
Closed

Increase default max_chunk_size to 1 GB #32208

devnoname120 opened this issue Apr 28, 2022 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@devnoname120
Copy link

devnoname120 commented Apr 28, 2022

Why is max_chunk_size set to 10 MB by default? That's pretty low.

What would you think about upping it to something like 1 GB?

Code reference:

$maxChunkSize = (int)\OC::$server->getConfig()->getAppValue('files', 'max_chunk_size', 10 * 1024 * 1024);

The weird thing is that the VM install script overrides this to 100 MB. Why is it different from the default?
https://github.com/nextcloud/vm/blob/c4b764acbd4fb3c66acb24cddfe21774a1363126/nextcloud_install_production.sh#L540

@devnoname120 devnoname120 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Apr 28, 2022
@devnoname120 devnoname120 changed the title Increase default max_chunk_size Increase default max_chunk_size to 1 GB Apr 28, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2022

just set the value to whatever you want

@szaimen szaimen closed this as completed Apr 28, 2022
@devnoname120
Copy link
Author

devnoname120 commented Apr 28, 2022

just set the value to whatever you want

Cloud-hosted NextCloud often provide the option modify the value, and they just keep the default.

Why can't we change the default?

@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2022

I tried :)
#26978

@devnoname120
Copy link
Author

@szaimen Any ideas if there is a way to fetch max_chunk_size from the API? I'm adding support for chunked upload in rclone.org and I'd like to programmatically determine the optimal chunk size (unless overriden by the user).

@szaimen
Copy link
Contributor

szaimen commented Apr 28, 2022

sry no idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

2 participants