Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner removePassword regex #26346

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Cleaner removePassword regex #26346

merged 1 commit into from
Jun 23, 2021

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Mar 27, 2021

No description provided.

@J0WI J0WI added the 3. to review Waiting for reviews label Mar 27, 2021
@J0WI
Cleaner removePassword regex
5f468c0 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@ChristophWurst
Copy link
Member

what problem does this solve?

@J0WI
Copy link
Contributor Author

J0WI commented Apr 16, 2021

This enhances the readability of the regex. When using another delimiter than / you don't need to escape every / with \/. I also added some more test cases with special chars.

@J0WI J0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 26, 2021
@kesselb kesselb added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 27, 2021
@J0WI J0WI requested a review from kesselb April 28, 2021 11:45
@J0WI J0WI added this to the Nextcloud 22 milestone Jun 23, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
@blizzz blizzz merged commit ee7a484 into nextcloud:master Jun 23, 2021
@J0WI J0WI deleted the clean-auth-regex branch June 23, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@J0WI @ChristophWurst @blizzz @kesselb