Merge pull request #26346 from J0WI/clean-auth-regex

Cleaner removePassword regex
nextcloud · Jun 23, 2021 · ee7a484 · ee7a484
2 parents c6d5653 + 5f468c0
commit ee7a484
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/private/Log/ErrorHandler.php b/lib/private/Log/ErrorHandler.php
@@ -39,7 +39,7 @@ class ErrorHandler {
 	 * @return string
 	 */
 	protected static function removePassword($msg) {
-		return preg_replace('/\/\/(.*):(.*)@/', '//xxx:xxx@', $msg);
+		return preg_replace('#//(.*):(.*)@#', '//xxx:xxx@', $msg);
 	}
 
 	public static function register($debug = false) {

diff --git a/tests/lib/ErrorHandlerTest.php b/tests/lib/ErrorHandlerTest.php
@@ -30,11 +30,15 @@ class ErrorHandlerTest extends \Test\TestCase {
 	 */
 	public function passwordProvider() {
 		return [
-			['user', 'password'],
-			['user@owncloud.org', 'password'],
-			['user', 'pass@word'],
+			['us:er', 'pass@word'],
 			['us:er', 'password'],
+			['user', '-C:R,w)@6*}'],
 			['user', 'pass:word'],
+			['user', 'pass@word'],
+			['user', 'password'],
+			['user:test@cloud', 'password'],
+			['user@owncloud.org', 'password'],
+			['user@test@owncloud.org', 'password'],
 		];
 	}