-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not lower case search provider names on web ui #25312
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
/backport to stable20 |
you didn't build production, right? |
oops |
/compile amend /core/ |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
ce66dc3
to
10f3033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me but I think this was there for a reason
The backport to stable20 failed. Please do this backport manually. |
It was there to be correct in English. The current way this string is build is just not conforming with our translation system. But due to the lack of other ideas... (So it actually comes from the rule that in English we uppercase the first word always, because 'Talk', 'Files', and the other search provider names should actually not be uppercase to begin with.) |
fixes #25282