Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search provider names in unified search hint do not respect localized language rules #25282

Closed
blizzz opened this issue Jan 22, 2021 · 2 comments · Fixed by #25312
Closed

Search provider names in unified search hint do not respect localized language rules #25282

blizzz opened this issue Jan 22, 2021 · 2 comments · Fixed by #25312
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: language l10n and translations feature: search

Comments

@blizzz
Copy link
Member

blizzz commented Jan 22, 2021

Fits:

Screenshot_20210122_182232

Should be capitalised:

Screenshot_20210122_182352

It is not a translation issue. The search providers only have to provide a getName() method for a translated string. The provides all return it in capitalized fashion ("Apps", …). In core/src/views/UnifiedSearch.vue:47 they are hard-lowercased.

The best distinction is done by the translators however.

My suggestion would be to add another method (as another interface to avoid breakage) that would return a string to be used within a sentence. And fall back to getName(). The hard lowercasing in the view would be removed.

The alternative would be to only remove the forced lower cased, which would end up in a strange picture at least in English:

Screenshot_20210122_183238

@ChristophWurst @skjnldsv @jancborchardt what do you think?

@blizzz blizzz added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: search feature: language l10n and translations labels Jan 22, 2021
@nickvergessen
Copy link
Member

:placeholder="t('core', 'Search {types} …', { types: typesNames.join(', ').toLowerCase() })"

We already agreed on this before to drop the lower

@ChristophWurst
Copy link
Member

👍 I actually thought we had fixed that during Nextcloud 20 development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: language l10n and translations feature: search
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants