Do not show 2FA settings if the user has no providers available #25273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
reviewed
Jan 22, 2021
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
What about if the backupprovider is the onyl provider but it is still enabled?
There was a problem hiding this comment.
I tried to explain this on L97-98. If the backup codes provider is the only one, then we don't show the settings neither.
But now that I think about it maybe we should only hide this if there is no provide other than the backup provider and 2FA is not enforced.
Users who have it enforced should see the backup code provider settings.
ChristophWurst
force-pushed
the
enhancement/hide-two-factor-settings-if-no-providers
branch
from
36c6da6
to
d382146
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/hide-two-factor-settings-if-no-providers
branch
from
d382146
to
378f116
Compare
rullzer
approved these changes
Jan 22, 2021
MorrisJobke
deleted the
enhancement/hide-two-factor-settings-if-no-providers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13971
To test install a 2FA provider, then you will see the 2FA settings as a user. Once there is only the backup codes one left, the settings vanish.