Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personal Two-Factor Authentication settings visible even if no 2FA activated #13971

Closed
wiswedel opened this issue Feb 1, 2019 · 5 comments · Fixed by #25273
Closed

Personal Two-Factor Authentication settings visible even if no 2FA activated #13971

wiswedel opened this issue Feb 1, 2019 · 5 comments · Fixed by #25273
Assignees
@ChristophWurst
Labels
3. to review Waiting for reviews bug papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 21

Comments

@wiswedel
Copy link
Contributor

wiswedel commented Feb 1, 2019

Steps to reproduce

  1. Disable all 2FA apps (or never have activated one ever before)
  2. Go to Settings > Personal > Security

Expected behaviour

No settings for Two-Factor Authentication visible

Actual behaviour

Two-Factor Authentication settings for Backup code generation visible

Nextcloud version:

15.0.2
@wiswedel wiswedel added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 1, 2019
@rullzer
Copy link
Member

rullzer commented Feb 1, 2019

Well yes. You can still generate backups codes then.But maybe we could hide it... if there really is no other app available...

@ChristophWurst ?

@ChristophWurst
Copy link
Member

Sure, we could hide it in that case!

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Feb 1, 2019
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 1, 2019
@MinIsMin
Copy link

MinIsMin commented Feb 3, 2019

Then it should also hide the reminder notification about creating backup codes

@ChristophWurst ChristophWurst removed this from the Nextcloud 16 milestone Feb 11, 2019
@Keridos
Copy link

Keridos commented Jul 22, 2020

This seems to have deeper roots: https://help.nextcloud.com/t/nextcloud-19-canot-properly-disable-2fa/87968

@ChristophWurst ChristophWurst mentioned this issue Jan 22, 2021
Merged
@ChristophWurst
Copy link
Member

PR is at #25273

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 22, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Jan 22, 2021
@ChristophWurst ChristophWurst self-assigned this Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging a pull request may close this issue.

Do not show 2FA settings if the user has no providers available nextcloud/server
5 participants
@rullzer @ChristophWurst @wiswedel @Keridos @MinIsMin