[stable15] Use slient option to switch for regular file actions as well #15131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
rullzer,
MorrisJobke,
ChristophWurst,
skjnldsv and
danxuliu
ChristophWurst
approved these changes
Apr 16, 2019
MorrisJobke
approved these changes
Apr 16, 2019
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15057
When opening folders from the favorites quick access, the default file list is used instead of the
OCA.Files.FavoritesFileList, therefore we also need to call OCA.Files.App.setActiveView` with the silent option to avoid events being triggered, that may lead to a race condition, where the filelist switches to the root folder after opening.This is another fix for #13028 that was not catched by #14886
Note: Try testing without an open browser console, which seems to trigger the race condition more often. 🙈
Steps to reproduce: