-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use slient option to switch for regular file actions as well #15057
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Do you have caches disabled when the console is open? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test the before & after: works as advertised 👍
CI failure is unrelated |
/backport to stable16 |
/backport to stable15 |
backport to stable16 in #15108 |
The backport to stable15 failed. Please do this backport manually. |
@juliushaertl This was reported against stable15, mind to look into back porting this? |
stable15 in #15131 |
When opening folders from the favorites quick access, the default file list is used instead of the
OCA.Files.FavoritesFileList
, therefore we also need to call OCA.Files.App.setActiveView` with the silent option to avoid events being triggered, that may lead to a race condition, where the filelist switches to the root folder after opening.This is another fix for #13028 that was not catched by #14886
Note: Try testing without an open browser console, which seems to trigger the race condition more often. 🙈
Steps to reproduce: