Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slient option to switch for regular file actions as well #15057

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

juliusknorr
Copy link
Member

When opening folders from the favorites quick access, the default file list is used instead of the OCA.Files.FavoritesFileList, therefore we also need to call OCA.Files.App.setActiveView` with the silent option to avoid events being triggered, that may lead to a race condition, where the filelist switches to the root folder after opening.

This is another fix for #13028 that was not catched by #14886

Note: Try testing without an open browser console, which seems to trigger the race condition more often. 🙈

Steps to reproduce:

  • Create folder 1 with subfolder 11
  • favorite folder 1
  • Unfold the favorites navigation
  • Click on Folder 1
    image
  • Click on Folder 11 in the main file list

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv
Copy link
Member

Note: Try testing without an open browser console, which seems to trigger the race condition more often.

0UjJ7o2

@ChristophWurst
Copy link
Member

Try testing without an open browser console, which seems to trigger the race condition more often.

Do you have caches disabled when the console is open?

@juliusknorr
Copy link
Member Author

Do you have caches disabled when the console is open?

Yes.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the before & after: works as advertised 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 12, 2019
@ChristophWurst
Copy link
Member

CI failure is unrelated

@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone Apr 15, 2019
@MorrisJobke MorrisJobke merged commit ef72609 into master Apr 15, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/silent-view-change branch April 15, 2019 09:46
@MorrisJobke
Copy link
Member

/backport to stable16

@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable16 in #15108

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

The backport to stable15 failed. Please do this backport manually.

@juliushaertl This was reported against stable15, mind to look into back porting this?

@juliusknorr
Copy link
Member Author

stable15 in #15131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants