Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLGenerator should also generate OCS urls #11617

Closed
rullzer opened this issue Oct 4, 2018 · 1 comment · Fixed by #11622
Closed

URLGenerator should also generate OCS urls #11617

rullzer opened this issue Oct 4, 2018 · 1 comment · Fixed by #11622
Assignees
@rullzer
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Milestone
Nextcloud 15

Comments

@rullzer
Copy link
Member

rullzer commented Oct 4, 2018

Now that the AppFramework supports OCS alerady for quite some time. We should make sure we can also generate proper urls for it with the url generator.
@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels Oct 4, 2018
@rullzer rullzer self-assigned this Oct 4, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #4397 (Naughty words in generated URLs), #10471 (Improve URL detection), #3462 (wrong url to doc), #9005 (c), and #6271 (Theming kills pretty URL).

rullzer added a commit that referenced this issue Oct 4, 2018
@rullzer
Add function to generate urls for OCS routes
dc9266e 
fixes #11617

The OCS routes are only absolute for now as they are often exposed to
the outside anyway and are on a different endpoint than index.php in
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this issue Oct 4, 2018
Merged
1 task
rullzer added a commit that referenced this issue Oct 9, 2018
@rullzer
Add function to generate urls for OCS routes
6d764cb 
fixes #11617

The OCS routes are only absolute for now as they are often exposed to
the outside anyway and are on a different endpoint than index.php in
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer added a commit that referenced this issue Oct 9, 2018
@rullzer
Add function to generate urls for OCS routes
1f76b3a 
fixes #11617

The OCS routes are only absolute for now as they are often exposed to
the outside anyway and are on a different endpoint than index.php in
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer added a commit that referenced this issue Oct 9, 2018
@rullzer
Add function to generate urls for OCS routes
c97b427 
fixes #11617

The OCS routes are only absolute for now as they are often exposed to
the outside anyway and are on a different endpoint than index.php in
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 10, 2018
weeman1337 pushed a commit that referenced this issue Oct 28, 2018
@rullzer @weeman1337
Add function to generate urls for OCS routes
979cdb5 
fixes #11617

The OCS routes are only absolute for now as they are often exposed to
the outside anyway and are on a different endpoint than index.php in
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rullzer rullzer

Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging a pull request may close this issue.

Add function to generate urls for OCS routes nextcloud/server
3 participants
@rullzer @MorrisJobke @nextcloud-bot