Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naughty words in generated URLs #4397

Closed
dj-foxxy opened this issue Apr 19, 2017 · 7 comments
Closed

Naughty words in generated URLs #4397

dj-foxxy opened this issue Apr 19, 2017 · 7 comments

Comments

@dj-foxxy
Copy link

Just had a 1 in 14 million event occur[1]: Nextcloud generated a URL with a path that starts with a four letter word beginning with c. Now, I'm very progressive, but others might feel it's a slight. Is it worth having a map of naughty words to non-naughty strings?

Steps to reproduce

  1. Generate a random share URL
  2. Inspect for naughty sub-strings
  3. Repeat 1 and 2 approx. 7 million times.

[1] (26 + 26 + 10)^4 = 14,776,336

@nickvergessen
Copy link
Member

You had cunt in a public share link? Or where?

@dj-foxxy
Copy link
Author

@nickvergessen Yep, public share link right there at the front. Noticed a few days after it was sent to a customer.

@nickvergessen
Copy link
Member

nickvergessen commented Apr 19, 2017

That's a bit unfortunate, but I guess filtering everything out is hard. I just had JAVA inside my app token today.

The problem is, who decides whether a word is a naughty word, and which languages should we check? What happens with leed replacements? Because if they are still 13ad, I don't see a way to have a filter that's "small enough" to avoid problems.

Currently I'd personally just say "sorry, please regenerate on your own". ¯\_(ツ)_/¯

@dj-foxxy
Copy link
Author

I agreed. Just thought it was worth pointing out.

@nickvergessen
Copy link
Member

Btw the change calculation is wrong, it's actually: (26 + 26 + 10)^4 / 12

Because we have 15 chars, so there can be 12 beginnings for a 4 letter word.

@dj-foxxy
Copy link
Author

So, (15 + 15 + 10) ^ 4 = 2,560,000

With odds like that might need to reopen the issue :).

@dj-foxxy dj-foxxy reopened this Apr 19, 2017
@blizzz
Copy link
Member

blizzz commented Apr 19, 2017

When looking around for other incidents in a more or less similar fashion and it's handling with it: also the German national football team did not change the names of their players:

Kuntz Source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants