Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/share single note #1146

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Feature/share single note #1146

merged 3 commits into from
Nov 8, 2023

Conversation

luka-nextcloud
Copy link
Contributor

Resolves: #38

  • Front-end:
    • Add share button to note's menu
    • Add sharing indicator
    • Collapse navigation (left panel) when open sdebar
    • Handle restored event
  • Back-end:
    • Dispatch events to load Sidebar script and Viewer script
    • Handle event BeforeShareCreatedEvent to update share target

composer.json Outdated
@@ -1,6 +1,6 @@
{
"require-dev": {
"nextcloud/ocp": "dev-stable25@dev",
"nextcloud/ocp": "dev-master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this specific change, currently we still cover multiple nextcloud versions and want to run the psalm checks against the ocp package towards the lowest supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class OCP\Share\Events\BeforeShareCreatedEvent does not exist on "nextcloud/ocp": "dev-stable25@dev", . We are listening to this event here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it is only available since 28.

Let me check if there is a fallback we can use for that then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fallback and added the event to the stub for the static analysis tests.

@luka-nextcloud I just noticed that my previously added commit was overwritten with yours and repushed that. Quick hint, if you use git push --force-with-lease instead of just a force push you will get notified about changes that have been made in the meantime. https://git-scm.com/docs/git-push#Documentation/git-push.txt---no-force-with-lease

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for your tip.

lib/Service/Note.php Outdated Show resolved Hide resolved
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but otherwise this looks quite good 👍

@juliushaertl juliushaertl force-pushed the feature/share-single-note branch 2 times, most recently from 3d3ab31 to dd47097 Compare November 8, 2023 12:25
luka-nextcloud and others added 3 commits November 8, 2023 13:27
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 83208d2 into main Nov 8, 2023
9 checks passed
@juliushaertl juliushaertl deleted the feature/share-single-note branch November 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Share a single note / publish
2 participants