Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate advanced search to nc dialog #9865

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 16, 2024

fix #9836

b a
image image

@hamza221 hamza221 added 3. to review skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Jul 16, 2024
@hamza221 hamza221 requested a review from GretaD July 16, 2024 13:08
@hamza221 hamza221 self-assigned this Jul 16, 2024
@hamza221 hamza221 marked this pull request as draft July 16, 2024 13:09
@hamza221 hamza221 marked this pull request as ready for review July 16, 2024 13:12
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/design/migrate-advanced-search-to-ncdialog branch from 815f81c to 558440f Compare July 23, 2024 09:36
@hamza221 hamza221 enabled auto-merge July 23, 2024 09:36
@hamza221 hamza221 merged commit cef0ea3 into main Jul 23, 2024
27 checks passed
@hamza221 hamza221 deleted the fix/design/migrate-advanced-search-to-ncdialog branch July 23, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate advanced search dialogue to NcDialog
2 participants