-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ocs): add OCS extractor and workflow #9832
Conversation
935052b
to
0eea010
Compare
ffdbd82
to
402f4ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit check in the workflow is not necessary. We don't want to vendor the openapi output in git.
- Adjust
Lines 5 to 7 in b9bdff0
"composer install --no-dev -o", "npm install --deps", "npm run build", - The new vendor bin should be monitored by renovate bot. Add it to https://github.com/nextcloud/mail/blob/b9bdff0b88baf3b8f211059a07a129b4fd3ca8cc/renovate.json.
The check is necessary to detect errors, even if you don't want to commit the result. Otherwise you'll only learn of the problems once you try to do a release... |
@provokateurin I mean "Check openapi*.json and typescript changes" to go. "Regenerate OpenAPI" has to stay of course. |
402f4ef
to
b6c6517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new vendor bin should be monitored by renovate bot. Add it to https://github.com/nextcloud/mail/blob/b9bdff0b88baf3b8f211059a07a129b4fd3ca8cc/renovate.json. not necessary
ec0f3ea
to
bf54fb1
Compare
Squash harder |
bf54fb1
to
bebec3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only need nextcloud/openapi-extractor
in the bin, not the global composer.* files
Signed-off-by: Anna Larch <anna@nextcloud.com>
e410f33
to
e854dc7
Compare
Needed for #9749 and #9672